andrea/h5ai-flpsite
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Invalid argument supplied for foreach() in class-archive.php:139

Browse Source 
Before this change, when trying to download a folder oder single file via the download (nginx/php7.1-fpm) option I get below error.

```
[error] 22294#22294: *1376 FastCGI sent in stderr: "PHP message: PHP Warning:  Invalid argument supplied for foreach() in ..._h5ai/private/php/ext/class-archive.php on line 138
PHP message: PHP Stack trace:
PHP message: PHP   1. {main}() ..._h5ai/public/index.php:0
PHP message: PHP   2. Bootstrap::run() /..._h5ai/public/index.php:17
PHP message: PHP   3. Api->apply() /..._h5ai/private/php/class-bootstrap.php:19
PHP message: PHP   4. Api->on_download() /..._h5ai/private/php/core/class-api.php:20
PHP message: PHP   5. Archive->output() /..._h5ai/private/php/core/class-api.php:37
PHP message: PHP   6. Archive->add_hrefs() /..._h5ai/private/php/ext/class-archive.php:28" while reading response header from upstream, 
client: 10.0.2.2, server: localhost.dev, request: "POST /downloads/? HTTP/1.1",
upstream: "fastcgi://127.0.0.1:9000", host: "localhost.dev:28888", referrer: "http://localhost.dev:28888/downloads/"
```
This commit is contained in:
djtm 2017-04-24 03:09:21 +02:00 committed by GitHub
parent 44e53ab213
commit e2a743bca5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/_h5ai/private/php/ext/class-archive.php
View File

@ -135,6 +135,9 @@ class Archive {
} }
private function add_hrefs($hrefs) { private function add_hrefs($hrefs) {
if(!is_array($hrefs)){
$hrefs=array($hrefs);
}
foreach ($hrefs as $href) { foreach ($hrefs as $href) {
if (trim($href) === '') { if (trim($href) === '') {
continue; continue;