From 41540e3d9ef92690bcf29e4ca65af3dacbb877f0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 13 Dec 2025 02:56:24 +0000 Subject: [PATCH] Add clarifying comments to address code review feedback Co-authored-by: ShaYmez <76499782+ShaYmez@users.noreply.github.com> --- hblink3-docker-install.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hblink3-docker-install.sh b/hblink3-docker-install.sh index 25fb403..73304e3 100755 --- a/hblink3-docker-install.sh +++ b/hblink3-docker-install.sh @@ -101,8 +101,11 @@ install_docker_and_dependencies() { echo "docker-compose-plugin installed successfully" # Create wrapper script for docker-compose command compatibility # docker-compose-plugin provides 'docker compose' but scripts use 'docker-compose' + # Note: Using single quotes in heredoc ('EOF') prevents variable expansion for robustness if [ ! -f /usr/local/bin/docker-compose ]; then echo "Creating docker-compose wrapper script..." + # Create wrapper that forwards all commands to 'docker compose' + # Exit on failure is intentional - without this wrapper, all control scripts will fail if cat > /usr/local/bin/docker-compose << 'EOF' #!/bin/sh # Wrapper script to provide docker-compose command using docker compose plugin @@ -116,6 +119,8 @@ EOF exit 1 fi else + # Skip wrapper creation if docker-compose already exists + # This preserves existing installations (from apt or manual install) echo "docker-compose command already exists, skipping wrapper creation" fi else